Twitterlite refactored #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@taranvohra : I actually haven't looked at this particular example myself. I know @cellog put it together based on a performance issue that Twitter filed, in reduxjs/react-redux#686 . |
Collaborator
|
The Twitter-lite benchmark tests a constantly growing array, and is essentially unrealistic and unrelated to the issue it came from. Their issue seemed to be time between mapstate and render increased, but I haven't heard back yet to see if that is indeed true. If so, then we would need to use a different approach to run it. So basically, this benchmark can be made into anything we would like it to be |
Aslemammad
pushed a commit
to Aslemammad/react-state-benchmarks
that referenced
this pull request
May 30, 2021
* setup * stockticker refactored * randomized slice and pair to update" * twitterlite refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markerikson I refactored
twitter-litein the same waystocktickerwas refactored i.e. store having multiple slices. Please have a look. However, there are some things that have been untouched such as the<TwitterLite />component where there were someconnectcalls which maybe you would be able to explain better (their purpose)